Get Opera Ready for MV3 #13190

justindbaur · 2025-01-31T20:02:33Z

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17198

📔 Objective

This gets Opera ready for MV3, it adds opera entries into the manifest.v3.json file so that the sidebar is available. Currently the ability to set the sidebar icon is broken so we are skipping that for now. The badge number is still working fine though. We just won't get the gray icon or the blue plus locked icon. Those icons still work fine for the popup action though.

📸 Screenshots

Logged out:

Unlocked with ciphers for page:

Locked:

Unlocked with no ciphers for page:

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

github-actions · 2025-01-31T20:12:14Z

Checkmarx One – Scan Summary & Details – bebc2165-6fd4-4b61-9e01-3f13810e791f

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	Angular_Improper_Type_Pipe_Usage	/apps/web/src/app/tools/send/send-access/access.component.html: 38	details The value used in expirationDate at /apps/web/src/app/tools/send/send-access/access.component.html in line 38 may throw an exception with the pipe ... Attack Vector

codecov · 2025-01-31T20:13:34Z

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 35.28%. Comparing base (9f22a2f) to head (e1689da).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
apps/browser/src/platform/browser/browser-api.ts	0.00%	5 Missing ⚠️
...pps/browser/src/platform/listeners/update-badge.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13190      +/-   ##
==========================================
- Coverage   35.28%   35.28%   -0.01%     
==========================================
  Files        3124     3124              
  Lines       92358    92349       -9     
  Branches    16794    16793       -1     
==========================================
- Hits        32590    32586       -4     
+ Misses      57311    57306       -5     
  Partials     2457     2457

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…clients into ps/pm-17198/opera-mv3

justindbaur · 2025-02-11T18:48:15Z

apps/browser/src/platform/listeners/update-badge.ts

@@ -165,6 +165,13 @@ export class UpdateBadge {
      return;
    }

+    if ("opr" in this.win && BrowserApi.isManifestVersion(3)) {
+      // setIcon API is currenly broken for Opera MV3 extensions
+      // https://forums.opera.com/topic/75680/opr-sidebaraction-seticon-api-is-broken-access-to-extension-api-denied?_=1738349261570


Clickable link:

https://forums.opera.com/topic/75680/opr-sidebaraction-seticon-api-is-broken-access-to-extension-api-denied?_=1738349261570

justindbaur · 2025-02-11T18:49:07Z

apps/browser/src/manifest.v3.json

+    "__opera___execute_sidebar_action": {
+      "suggested_key": {
+        "default": "Alt+Shift+Y",
+        "linux": "Alt+Shift+U"
+      },
+      "description": "__MSG_commandOpenSidebar__"
+    },


Copy from MV2 manifest:

clients/apps/browser/src/manifest.json

Lines 106 to 112 in 65024a1

"__opera___execute_sidebar_action": {

"suggested_key": {

"default": "Alt+Shift+Y",

"linux": "Alt+Shift+U"

},

"description": "__MSG_commandOpenSidebar__"

},

justindbaur · 2025-02-11T19:35:01Z

apps/browser/src/manifest.v3.json

+  "__opera__sidebar_action": {
+    "default_title": "Bitwarden",
+    "default_panel": "popup/index.html?uilocation=sidebar",
+    "default_icon": "images/icon19.png",
+    "open_at_install": false,
+    "browser_style": false
+  }


Copy from MV2 manifest:

clients/apps/browser/src/manifest.json

Lines 160 to 166 in 65024a1

"__opera__sidebar_action": {

"default_title": "Bitwarden",

"default_panel": "popup/index.html?uilocation=sidebar",

"default_icon": "images/icon19.png",

"open_at_install": false,

"browser_style": false

},

justindbaur added 3 commits January 31, 2025 14:48

Add Opera Sidebar Related Manifest Keys

87845d5

Be stricter about where sidebar API's come from

f8d6728

Skip Sidebar Icon Changes in MV3

f5c3b5d

justindbaur requested a review from a team as a code owner January 31, 2025 20:02

justindbaur requested a review from tangowithfoxtrot January 31, 2025 20:02

justindbaur marked this pull request as draft January 31, 2025 20:02

justindbaur marked this pull request as ready for review February 3, 2025 14:07

justindbaur added 5 commits February 10, 2025 15:23

Merge branch 'main' into ps/pm-17198/opera-mv3

09bbb90

Fix typo in comment

0ac4c40

Merge branch 'ps/pm-17198/opera-mv3' of https://github.com/bitwarden/…

76e3ef0

…clients into ps/pm-17198/opera-mv3

Merge remote-tracking branch 'origin/main' into ps/pm-17198/opera-mv3

6fd927e

Add open_at_install

e1689da

justindbaur commented Feb 11, 2025

View reviewed changes

tangowithfoxtrot approved these changes Feb 11, 2025

View reviewed changes

justindbaur merged commit 5f2a773 into main Feb 11, 2025
45 checks passed

justindbaur deleted the ps/pm-17198/opera-mv3 branch February 11, 2025 20:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get Opera Ready for MV3 #13190

Get Opera Ready for MV3 #13190

justindbaur commented Jan 31, 2025

github-actions bot commented Jan 31, 2025 •

edited

Loading

codecov bot commented Jan 31, 2025 •

edited

Loading

justindbaur Feb 11, 2025

justindbaur Feb 11, 2025

justindbaur Feb 11, 2025

	"__opera___execute_sidebar_action": {
	"suggested_key": {
	"default": "Alt+Shift+Y",
	"linux": "Alt+Shift+U"
	},
	"description": "__MSG_commandOpenSidebar__"
	},

	"__opera__sidebar_action": {
	"default_title": "Bitwarden",
	"default_panel": "popup/index.html?uilocation=sidebar",
	"default_icon": "images/icon19.png",
	"open_at_install": false,
	"browser_style": false
	},

Get Opera Ready for MV3 #13190

Get Opera Ready for MV3 #13190

Conversation

justindbaur commented Jan 31, 2025

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

🦮 Reviewer guidelines

github-actions bot commented Jan 31, 2025 • edited Loading

codecov bot commented Jan 31, 2025 • edited Loading

Codecov Report

justindbaur Feb 11, 2025

Choose a reason for hiding this comment

justindbaur Feb 11, 2025

Choose a reason for hiding this comment

justindbaur Feb 11, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 31, 2025 •

edited

Loading

codecov bot commented Jan 31, 2025 •

edited

Loading